fix(agents): accept generation kwargs on LlmAgent - #6837
Open
a2105z wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Users coming from google-genai pass temperature= (and similar knobs) on LlmAgent, which failed with extra_forbidden and no pointer to generate_content_config. Fold GenerateContentConfig fields into that config, and point reserved fields at the LlmAgent argument that owns them. Fixes google#6836
a2105z
force-pushed
the
fix/llm-agent-generation-kwargs
branch
from
August 20, 2026 20:54
8fe8946 to
9c94f11
Compare
Contributor
Author
|
@googlebot I fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LlmAgent(temperature=0.1)(and otherGenerateContentConfigknobs such astop_pandmax_output_tokens) now folds intogenerate_content_configinstead of failing withextra_forbidden.system_instruction,response_schema) raise a message that points atinstruction=/output_schema=; setting the same field both as a kwarg and insidegenerate_content_configis rejected.LlmAgentclass andgenerate_content_configfield docstrings now document the mapping.Closes: #6836
Test plan
Unit Tests:
Covers the original crash (
temperature=withoutput_schema), merging with an existinggenerate_content_config, camelCase aliases, thinking_config kwargs, reserved-field redirects, conflicts, and unknown extras remaining forbidden.Manual End-to-End (E2E) Tests:
Previously this raised
ValidationError: temperature Extra inputs are not permitted.Checklist